Fix: Enable Vertical Scrolling for Company Filter Dropdown #8828
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Adds vertical scrolling functionality to the company filter dropdown by wrapping dropdown content in a ScrollWrapper component to enable access to all options.
- Added
ScrollWrappercomponent in/packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/MultipleFiltersDropdownContent.tsxto enable vertical scrolling - Implemented with specific context provider name for dropdown menu items to maintain proper scroll behavior
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -41,7 +42,7 @@ export const MultipleFiltersDropdownContent = ({ | |||
| const shoudShowFilterInput = objectFilterDropdownFilterIsSelected; | |||
There was a problem hiding this comment.
syntax: 'shoudShowFilterInput' is misspelled (missing 'l')
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
@mdrazak2001 Could you please put the scroll wrapper so that we only have the menu item part scrollable ? 
|
|
Is it a regression? Can't reproduce on V33.5 CleanShot.2024-12-02.at.10.22.38.mp4 |
@Bonapara |
|
@lucasbordeau maybe you know? |
|
Yes it's a regression, I can reproduce, I could take it in my PR because I'm currently fixing a lot of related regressions on dropdown. Let's close this one, thank you for your understanding @mdrazak2001 |
Fixes #8827
Screen.Recording.2024-12-02.133204.mp4